Skip to content

fix(ci): guard empty commits[@] expansion in reconcile_platform_wheels.sh #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nakanokensetsu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ci): guard empty commits[@] expansion in reconcile_platform_wheels.sh #1784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/scripts/reconcile_platform_wheels.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,10 @@ echo "Platform: ${PLATFORM_BACKEND}/${PLATFORM_ARCHITECTURE}"
echo "Last contiguous build: ${last_built:-none}"
echo "Commits requiring reconciliation: ${#commits[@]}"

# "${commits[@]}" on a genuinely empty array trips "unbound variable" under
# `set -u` on bash < 4.4 (macOS system /bin/bash is 3.2.57); ${#commits[@]}
# is safe either way, so gate the loop on the count instead.
if ((${#commits[@]} > 0)); then
for commit in "${commits[@]}"; do
restore_tracked_build_changes
git checkout --detach "$commit"
Expand Down Expand Up @@ -229,6 +233,7 @@ for commit in "${commits[@]}"; do

printf '%s\n' "$commit" | "$rclone" rcat "$state_remote"
done
fi

restore_tracked_build_changes
git checkout --detach "$target_commit"
Expand Down
Loading