Repository navigation
Refactor assistant source formatting out of Swing UI - #79
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChatPanelinto a package-private, Swing-independentAssistantSourceFormatterChatPanelChatPanelTestcoverage with direct deterministic unit tests, including disabled-search and answer-URL fallback casesDesign
This is intentionally a narrow extraction: one concrete stateless class, no interface, dependency injection, coordinator chain, or new lifecycle. The formatter accepts only the values it needs (
String,List<CitationRef>, and the Web Search enabled flag) and remains unaware ofChatPanel,SendJob,StreamingSession, Swing, or persistence.ChatPanelis reduced by 177 production lines while retaining orchestration and UI responsibilities.Testing
mvn -B -ntp -Dtest=AssistantSourceFormatterTest,ChatPanelTest testmvn -B -ntp verify— 2,889 tests, 0 failures/errors, 5 skipped; isolated shaded runtime verification passed