Skip to content

Gui: redesign Macros dialog layout for clarity - #1

Open
dragonfruit-blue wants to merge 1 commit into
mainfrom
issue-2
Open

dragonfruit-blue wants to merge 1 commit into
mainfrom
issue-2

Conversation

@dragonfruit-blue

@dragonfruit-blue dragonfruit-blue commented Mar 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • Renames the dialog title from "Execute Macro" to "Macros" to better reflect its full scope (execute, create, edit, rename, duplicate, delete, toolbar setup, download)
  • Removes the confusing "Macro Name" group box wrapper; replaces it with a clean "Selected:" label row below the macro list
  • Moves search fields ("Find file" / "Find in files") to a dedicated top row, no longer buried inside a group box
  • Reorganizes the button column into logical groups separated by visible divider lines:
    • Execute (primary action, at top)
    • Create / Edit / Rename / Duplicate / Delete (file management)
    • Toolbar / Download (secondary actions)
    • Close (bottom)
  • Fixes tab bar label clipping by enforcing a minimum width per tab

No .cpp changes — all widget object names are preserved, so all existing signal/slot connections and logic remain intact.

Test plan

  • Open Macro menu → Macros... and verify dialog title shows "Macros"
  • Verify both "User macros" and "System macros" tab labels are fully visible
  • Verify separator lines are visible between button groups
  • Verify Execute, Edit, Delete, Rename, Duplicate, Toolbar buttons enable/disable correctly on selection
  • Verify double-clicking a macro executes it
  • Verify Create, Rename, Duplicate, Delete operations work correctly
  • Verify Toolbar walkthrough and Download (Addon Manager) buttons work
  • Verify User Macros Location path chooser and Open Folder button work

🤖 Generated with Claude Code

Reorganize the Macros dialog (formerly "Execute Macro") to more
effectively guide users through the available actions:

- Rename window title from "Execute Macro" to "Macros"
- Remove confusing "Macro Name" group box wrapper
- Move search fields (Find file, Find in files) to a clean top row
- Place "Selected:" label inline below the macro list
- Reorder button column: Execute (primary) → Create/Edit/Rename/
  Duplicate/Delete (file management) → Toolbar/Download (secondary)
  → Close (bottom), with visible separator lines between groups
- Fix tab bar clipping by enforcing min-width on each tab

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Thanks for helping improve FreeCAD!
This pull request hasn’t seen activity in a while. We automatically check each PR after 120 days without activity to keep the repository tidy.

If the PR is still relevant, let us know by adding a comment.
Otherwise, we’ll close this PR automatically in 60 days.

If you would like to keep working on this pull request, we advice to rebase it on current main branch, ask feedback from users or maintainers and engage with the community to get it forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant