Skip to content

Fix RFC 7230 §3.3.3 violation: Transfer-Encoding takes precedence over Content-Length #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dragosv merged 3 commits into from
Mar 5, 2026
Merged

Fix RFC 7230 §3.3.3 violation: Transfer-Encoding takes precedence over Content-Length #5

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3da803
Initial plan
Copilot Mar 5, 2026
3e5c286
Fix HTTP spec violation: check chunked before content_length per RFC …
Copilot Mar 5, 2026
511d5d7
Merge branch 'unixsocket' into copilot/sub-pr-1-another-one
dragosv Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/docker_client.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,10 +186,13 @@ fn parseResponseHead(reader: *HttpReader) !ResponseMeta {
}

/// Read the full response body according to the parsed metadata.
/// Per RFC 7230 §3.3.3, Transfer-Encoding takes precedence over Content-Length
/// when both are present.
fn readResponseBody(reader: *HttpReader, meta: ResponseMeta, allocator: std.mem.Allocator) ![]const u8 {
if (meta.chunked) {
return readChunkedBody(reader, allocator);
}

if (meta.content_length) |cl| {
if (cl == 0) return allocator.dupe(u8, "");
const body_buf = try allocator.alloc(u8, cl);
Expand Down