Skip to content

add lint/typecheck for desktop app #15

Description

@draylegend

apps/app/project.json has a lint target; apps/desktop/project.json doesn't. nx run-many -t lint (what CI runs) silently skips projects with no matching target, so apps/desktop/src (the Bun main-process shell) currently has zero automated lint or typecheck coverage — confirmed via nx show projects + nx run-many -t lint --dry-run, which only ever touches app.

This is the same category of bug AGENTS.md already warns about (Bun-side code getting mixed up with Angular's browser-lib tsconfig) — right now nothing would catch a regression there until it breaks at runtime.

Note: adding a typecheck step isn't a straight tsc -p apps/desktop/tsconfig.json --noEmit — see the linked electrobun issue, its shipped types currently fail against this repo's exactOptionalPropertyTypes: true. That'll need resolving (or scoping around) first.

Next steps:

  • add an eslint lint target to apps/desktop/project.json
  • decide how to typecheck apps/desktop/src given the electrobun blocker

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions