Fix Mac build to actually use VCPKG for LLVM.#16
Open
lriggs wants to merge 4 commits intodremio:dremio_27.0_20from
Open
Fix Mac build to actually use VCPKG for LLVM.#16lriggs wants to merge 4 commits intodremio:dremio_27.0_20from
lriggs wants to merge 4 commits intodremio:dremio_27.0_20from
Conversation
Add action url to release Add action url to release
Old grpc uninstall causing error? fix vcpkg root error Fix vcpgkg llvm for mac. vcpkg vcpkg Go back to brew for build tools. vcpkg just for llvm Update macos path fix path to system files vcpkg vcpkg vcpkg fix re2 dependency Make JNI CMake args more robust - Check if protobuf_ep-install exists before adding Protobuf_ROOT - Check if re2_ep-install exists before adding re2_ROOT - This handles cases where system dependencies are used instead of bundled Use vcpkg RE2 instead of bundled RE2 for macOS Gandiva build vcpkg installs RE2 as a dependency of LLVM. When we use bundled RE2, the Arrow C++ build compiles Gandiva against vcpkg's RE2 headers (which use std::string_view API) but links against bundled RE2 (which uses StringPiece API), causing linker errors. This change uses vcpkg's RE2 for both compilation and linking when vcpkg LLVM is used, ensuring ABI compatibility.
fix release notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Fix Mac build to actually use VCPKG for LLVM.
Add tracking info to release notes.