DX-113970 Backport "GH-48160 Pass CPU attributes to LLVM"#118
Merged
lriggs merged 1 commit intodremio:dremio_26.1_18.1.0from Feb 10, 2026
Merged
DX-113970 Backport "GH-48160 Pass CPU attributes to LLVM"#118lriggs merged 1 commit intodremio:dremio_26.1_18.1.0from
lriggs merged 1 commit intodremio:dremio_26.1_18.1.0from
Conversation
lriggs
reviewed
Feb 7, 2026
lriggs
approved these changes
Feb 7, 2026
) The CPU attributes are not passed to the LLVM layer, which means potential optimizations could be missed leading to inefficient code. This feature was lost as part of the refactoring in apache@83cba25 I also discovered a bug with decimal alignments that was exposed by this change and was only reproducible in our test environment. Pass the CPU attributes to the LLVM code generation, and a unit test. Fix the 16 bit vs 8 bit decimal alignment problem. This was causing a crash sometimes on certain architectures with certain queries. Added a unit test. Yes. No. * GitHub Issue: apache#48160 Lead-authored-by: Logan Riggs <logan.riggs@dremio.com> Co-authored-by: lriggs <logan.riggs@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
akravchukdremio
force-pushed
the
DX-113970-26.1
branch
from
070071e to
021b3b9
Compare
lriggs
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.