Skip to content

Changing the title of the webpage#5

Open
aguthals wants to merge 2 commits into
drguthals:masterfrom
aguthals:master
Open

Changing the title of the webpage#5
aguthals wants to merge 2 commits into
drguthals:masterfrom
aguthals:master

Conversation

@aguthals
Copy link
Copy Markdown

@aguthals aguthals commented Mar 2, 2018

I thought the title could use a little excitement!

Copy link
Copy Markdown
Owner

@drguthals drguthals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for suggesting the new title! Can you just take your name out of it?

Comment thread codingEnvironment.html
<div style="height:100%;margin-left:10px;margin-right:10px;">
<div style=" position:relative; margin-bottom:8px; text-align:center;">
<h1>CSE 190 Blockly Playground: Project 3</h1>
<h1>Adrian's AWESOME Blockly Playground</h1>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't have your name on the webpage, since this is a project for everyone :)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks ok

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, do that

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responding to a comment to start a review

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responding again to start

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replying to one

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replying to start

@drguthals drguthals dismissed their stale review March 5, 2018 21:37

Because whatever

Copy link
Copy Markdown
Owner

@drguthals drguthals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another test to request changes

Copy link
Copy Markdown
Owner

@drguthals drguthals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking this out

Comment thread codingEnvironment.html
<div style="height:100%;margin-left:10px;margin-right:10px;">
<div style=" position:relative; margin-bottom:8px; text-align:center;">
<h1>CSE 190 Blockly Playground: Project 3</h1>
<h1>Adrian's AWESOME Blockly Playground</h1>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks ok

Copy link
Copy Markdown
Owner

@drguthals drguthals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change things

Comment thread codingEnvironment.html
<div style="height:100%;margin-left:10px;margin-right:10px;">
<div style=" position:relative; margin-bottom:8px; text-align:center;">
<h1>CSE 190 Blockly Playground: Project 3</h1>
<h1>Adrian's AWESOME Blockly Playground</h1>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, do that

Copy link
Copy Markdown
Owner

@drguthals drguthals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at my file comments

Comment thread codingEnvironment.html
<div style=" position:relative; margin-bottom:8px; text-align:center;">
<h1>CSE 190 Blockly Playground: Project 3</h1>
<h1>Adrian's AWESOME Blockly Playground</h1>
</div>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondring about this one too though.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing replying to a comment in 2017 experimental

Copy link
Copy Markdown
Owner

@drguthals drguthals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Review

Copy link
Copy Markdown
Owner

@drguthals drguthals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And submitting this review

Comment thread codingEnvironment.html
<div style="height:100%;margin-left:10px;margin-right:10px;">
<div style=" position:relative; margin-bottom:8px; text-align:center;">
<h1>CSE 190 Blockly Playground: Project 3</h1>
<h1>Adrian's AWESOME Blockly Playground</h1>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responding to a comment to start a review

Copy link
Copy Markdown
Owner

@drguthals drguthals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And submitting agian

Comment thread codingEnvironment.html
<div style="height:100%;margin-left:10px;margin-right:10px;">
<div style=" position:relative; margin-bottom:8px; text-align:center;">
<h1>CSE 190 Blockly Playground: Project 3</h1>
<h1>Adrian's AWESOME Blockly Playground</h1>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responding again to start

Copy link
Copy Markdown
Owner

@drguthals drguthals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and submitting an approved in 2017 experimental

Comment thread codingEnvironment.html
<div style=" position:relative; margin-bottom:8px; text-align:center;">
<h1>CSE 190 Blockly Playground: Project 3</h1>
<h1>Adrian's AWESOME Blockly Playground</h1>
</div>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing replying to a comment in 2017 experimental

Comment thread codingEnvironment.html
<h1>CSE 190 Blockly Playground: Project 3</h1>
<h1>Adrian's AWESOME Blockly Playground</h1>
</div>
<div style="margin-left:50%;width:50%;">
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding my comment

Comment thread codingEnvironment.html
<h1>Adrian's AWESOME Blockly Playground</h1>
</div>
<div style="margin-left:50%;width:50%;">
<img onclick="runCode()" src="images/runButton.png"/>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding another one

Comment thread codingEnvironment.html
@@ -49,7 +49,7 @@

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And another one

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replying

Comment thread codingEnvironment.html
<div style="height:100%;margin-left:10px;margin-right:10px;">
<div style=" position:relative; margin-bottom:8px; text-align:center;">
<h1>CSE 190 Blockly Playground: Project 3</h1>
<h1>Adrian's AWESOME Blockly Playground</h1>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replying to one

Copy link
Copy Markdown
Owner

@drguthals drguthals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicked CONTINUE YOUR REVIEW and now I'm submitting here.

Comment thread codingEnvironment.html
@@ -49,7 +49,7 @@

<div style="height:100%;margin-left:10px;margin-right:10px;">
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting my review from here instead of clicking on ADD YOUR REIVEW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants