Skip to content

fix(design-system): virtual table height is hardcoded to 600px [AR-80447] #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iromanchuk-dn merged 2 commits into from
Aug 3, 2026
Merged

fix(design-system): virtual table height is hardcoded to 600px [AR-80447] #633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e59a90
fix(design-system): virtual table height is hardcoded to 600px [AR-80…
iromanchuk-dn Aug 3, 2026
41c0245
remove unused var
iromanchuk-dn Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/icy-horses-search.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@drivenets/design-system': patch
---

Fix virtual table height by filling parent element height
3 changes: 2 additions & 1 deletion packages/design-system/src/components/ds-table/ds-table.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ $bulk-actions-reserved-space: 80px;
background: var(--background);
display: flex;
flex-direction: column;
height: 100%;
max-height: 100%;
overflow: hidden;
}
Expand Down Expand Up @@ -122,11 +123,11 @@ $bulk-actions-reserved-space: 80px;

.virtualizedContainer {
position: relative;
height: vars.$virtualized-height;
overflow-x: auto;
overflow-y: hidden;
display: flex;
flex-direction: column;
flex: 1;

@include scrollbars.scrollbar-on-hover;

Expand Down
6 changes: 1 addition & 5 deletions packages/design-system/src/components/ds-table/stories/ds-table-virtualized.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,11 +459,7 @@ export const VirtualizedWithControls: Story = {
render: function Render(args) {
const [data] = useState(() => generatePersonData(0, VIRTUALIZED_ROW_COUNT, []).data);

return (
<div className={styles.virtualizedTableWrapper}>
<DsTable {...args} data={data} virtualized />
</div>
);
return <DsTable {...args} data={data} virtualized />;
},
args: {
controls: (
Expand Down
5 changes: 5 additions & 0 deletions packages/design-system/src/components/ds-table/stories/ds-table.stories.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,11 @@
}

.virtualizedDemoContainer {
display: flex;
flex-direction: column;
gap: 1rem;
position: relative;
height: 100%;
}

.virtualizedDemoHeader {
Expand Down Expand Up @@ -201,6 +205,7 @@

.virtualizedTableWrapper {
position: relative;
flex: 1;
}

.loadingOverlay {
Expand Down
1 change: 0 additions & 1 deletion packages/design-system/src/components/ds-table/styles/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
$border-radius: 4px;
$border-width: 1px;
$group-border-width: 2px;
$virtualized-height: 600px;
$reorder-column-width: 60px;
$container-margin-vertical: 1rem;
$filter-input-gap: 0.5rem;
Expand Down
Loading