Update mariadb support, versions, add display names, fix circleci testing #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update mailboxAdd.go
eddiewebb
commented
Dec 18, 2021
Author
eddiewebb
left a comment
eddiewebb
left a comment
There was a problem hiding this comment.
Looking at all the chamnges the version checks were ripped out entirely, will need to reintroduce and make sure displayname support and any other changes aloign.
| } | ||
|
|
||
| //TODO use version.EASY boolean to check semver style or new easy date tag style | ||
| return nil |
Author
There was a problem hiding this comment.
Whoops lol, not sute where that was introduced, ill work on unwinding and adding easy and standard version config
| ) | ||
|
|
||
| type iredMailVersion string | ||
| type iredMailVersion struct { |
Author
There was a problem hiding this comment.
allows distinction of new 'easy' versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically shoving 4 downstream forks and ~60 commits IN CASE original maintainer/author cares to keep this hobbling along.