Skip to content

refactor: integrate mobilerun-core-cli for portal and driver primitives#351

Merged
RasulOs merged 2 commits into
mainfrom
refactor/integrate-mobilerun-core-cli
Jun 3, 2026
Merged

refactor: integrate mobilerun-core-cli for portal and driver primitives#351
RasulOs merged 2 commits into
mainfrom
refactor/integrate-mobilerun-core-cli

Conversation

@lutz-grex
Copy link
Copy Markdown
Contributor

No description provided.

@RasulOs
Copy link
Copy Markdown
Collaborator

RasulOs commented Jun 3, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3f36f3dbe0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread mobilerun/tools/driver/__init__.py
Copy link
Copy Markdown
Collaborator

RasulOs commented Jun 3, 2026

Codex:

Follow-up on the existing mobilerun.tools.driver.android compatibility comment: after checking the PR tree, there do not appear to be internal runtime imports of the old submodule paths anymore, and the docs examples already use the stable public import (from mobilerun.tools import AndroidDriver).

So the practical fix can just be updating/removing the stale generated docs anchors that still point to deleted implementation modules, e.g. mobilerun.tools.driver.android.AndroidDriver in docs/sdk/adb-tools.mdx and mobilerun.tools.driver.base.DeviceDriver in docs/sdk/base-tools.mdx.

Old anchors referenced mobilerun.tools.driver.{android,base} submodules
that no longer exist after the mobilerun-core-cli integration.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@RasulOs RasulOs merged commit ece3920 into main Jun 3, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants