Return status code 500 (instead of 200) when there's a run time error#781
Open
amandasaurus wants to merge 1 commit intodrolbr:masterfrom
Open
Return status code 500 (instead of 200) when there's a run time error#781amandasaurus wants to merge 1 commit intodrolbr:masterfrom
amandasaurus wants to merge 1 commit intodrolbr:masterfrom
Conversation
HTTP 200 is for when there is no problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP 200 is for when there is no problem.
In my experience, if something happens to an overpass server, you can get
runtime error: open64: 2 No such file or directory /ssd/overpass-database//osm3s_v0.7.58_osm_base Unix_Socket::7. However when this happens the HTTP status code is 200. With this patch, the HTTP status code will be 500.This allows the existance, or occurance, of this error to be detected, logged, with potential automatic failover happening.