Implement codec for xsd:positiveInteger data type

[mark-dropbear]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @mark-dropbear, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for the xsd:positiveInteger data type, expanding the library's capability to correctly parse and serialize XML Schema-defined integer values. The changes include the core codec implementation, its associated encoder and decoder, and a dedicated test suite to validate its behavior.

Highlights

• New xsd:positiveInteger Codec: Implemented XmlPositiveIntegerCodec to handle the xsd:positiveInteger XML Schema data type. This codec converts between string representations and Dart's BigInt type, ensuring that only positive integer values (greater than or equal to 1) are processed.
• Comprehensive Unit Tests: Added positive_integer_codec_test.dart with extensive unit tests for the new codec. These tests cover successful conversions, as well as error handling for invalid inputs such as zero, negative numbers, empty strings, and non-integer formats, ensuring robustness.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly implements the codec for the xsd:positiveInteger data type. The implementation is robust, using BigInt to support arbitrarily large integers and correctly validating the input according to the XSD specification. The accompanying tests are comprehensive for valid and invalid inputs. I've added a couple of suggestions to further improve the code: one to enhance test coverage for whitespace handling, and another to reduce code duplication by sharing a constant between the encoder and decoder. Overall, this is a solid contribution.