Skip to content

feat: add xsd:nonPositiveInteger codec - #53

Merged
mark-dropbear merged 2 commits into
mainfrom
52-implement-codec-for-xsdnonpositiveinteger-data-type
Sep 6, 2025
Merged

mark-dropbear merged 2 commits into
mainfrom
52-implement-codec-for-xsdnonpositiveinteger-data-type

Conversation

@mark-dropbear

Copy link
Copy Markdown
Contributor

No description provided.

@mark-dropbear mark-dropbear linked an issue Sep 6, 2025 that may be closed by this pull request

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @mark-dropbear, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the library's XML Schema datatype handling by introducing full support for xsd:nonPositiveInteger. This enhancement allows the system to correctly parse, validate, and serialize integer values that are zero or negative, aligning the library more closely with the XSD 1.1 standard.

Highlights

  • New XSD Datatype Support: Implemented a new codec for xsd:nonPositiveInteger, allowing for proper encoding and decoding of non-positive integer values according to the XML Schema Definition (XSD) 1.1 specification.
  • Data Type Validation: The new codec includes robust validation to ensure that only non-positive integer values (less than or equal to zero) are processed, throwing FormatException for invalid inputs during both encoding and decoding.
  • Documentation and Testing: Updated CHANGELOG.md and README.md to reflect the new datatype support, and comprehensive unit tests have been added to ensure the correctness and reliability of the xsd:nonPositiveInteger codec.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a codec for the xsd:nonPositiveInteger data type, complete with an encoder, decoder, and unit tests. The implementation is well-structured and aligns with the existing patterns in the project. I have one minor suggestion to correct a typo in the test file for better consistency.

Comment thread test/codecs/non_positive_integer_codec_test.dart Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@mark-dropbear
mark-dropbear merged commit b0f8646 into main Sep 6, 2025
1 check passed
@mark-dropbear
mark-dropbear deleted the 52-implement-codec-for-xsdnonpositiveinteger-data-type branch September 6, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement codec for xsd:nonPositiveInteger data type

1 participant