Skip to content

feat: add xsd:gMonthDay codec and data type - #63

Merged
mark-dropbear merged 2 commits into
mainfrom
gMonthDay
Nov 26, 2025
Merged

mark-dropbear merged 2 commits into
mainfrom
gMonthDay

Conversation

@mark-dropbear

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @mark-dropbear, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the library's capabilities by adding support for the xsd:gMonthDay data type. It introduces a new GregorianMonthDay class to model this specific day-of-month concept, complete with constructors, parsing logic, and string serialization. The implementation ensures strict adherence to XSD validation rules for dates and timezones, making the library more compliant and versatile for XML Schema processing.

Highlights

  • New Data Type Implementation: Introduced full support for the xsd:gMonthDay XML Schema built-in data type, including its representation, parsing, and serialization.
  • Robust Validation: The new GregorianMonthDay class includes comprehensive validation for month, day, and optional timezone offset, ensuring data integrity according to XSD specifications.
  • Codec Integration: A dedicated GregorianMonthDayCodec has been added, facilitating seamless conversion between string representations and GregorianMonthDay objects.
  • Documentation and Testing: The CHANGELOG.md and README.md have been updated, and a thorough suite of unit tests has been added to verify the correctness and robustness of the new implementation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the xsd:gMonthDay data type, including the GregorianMonthDay class, its associated codec, and comprehensive unit tests. The implementation is well-structured and the tests cover a good range of cases. I've found a minor documentation error in the README and a few opportunities to improve code clarity by removing redundant code. Overall, great work on adding this new feature.

Comment thread README.md Outdated
Comment thread lib/src/types/gregorian_month_day.dart
Comment thread lib/src/types/gregorian_month_day.dart
Comment thread lib/src/types/gregorian_month_day.dart
Comment thread lib/src/types/gregorian_month_day.dart
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@mark-dropbear
mark-dropbear merged commit 3564423 into main Nov 26, 2025
1 check passed
@mark-dropbear
mark-dropbear deleted the gMonthDay branch November 26, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant