Skip to content

feat: add xsd:datetime codec and data type - #66

Merged
mark-dropbear merged 4 commits into
mainfrom
datetime-new
Nov 26, 2025
Merged

mark-dropbear merged 4 commits into
mainfrom
datetime-new

Conversation

@mark-dropbear

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @mark-dropbear, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the library's capability by adding full support for the xsd:dateTime data type. It introduces a custom XsdDateTime class designed to correctly interpret and manage date-time values according to XSD specifications, particularly concerning timezone information and 'floating' date-times. This ensures that date-time values can be accurately parsed from and serialized to XSD strings, maintaining data integrity across operations.

Highlights

  • New xsd:datetime Codec and Data Type: Introduced a new XsdDateTime class and its corresponding codec (XsdDateTimeCodec) to handle xsd:dateTime values, ensuring XSD-compliant parsing and serialization.
  • Timezone Preservation: The XsdDateTime class specifically addresses the challenge of 'floating' (timezone-less) xsd:dateTime values and preserves the original timezone offset for accurate round-tripping, which Dart's native DateTime class does not inherently support.
  • Documentation and Tests: The README.md has been updated to reflect support for xsd:dateTime, and comprehensive unit tests have been added to validate the parsing, equality, and comparison logic of the XsdDateTime class.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for the xsd:datetime data type. It adds a new XsdDateTime wrapper class to handle XSD's specific requirements for timezones, particularly 'floating' datetimes and preserving the original offset for round-tripping. A corresponding codec and unit tests are also included. The implementation is well-structured and the code is clear. I've left a couple of suggestions for minor improvements: one to simplify the code in the XsdDateTime class and another to enhance the test suite with cases for fractional seconds.

Comment on lines +94 to +96
final us = (dt.microsecond > 0)
? (dt.microsecond % 1000).toString().padLeft(3, '0')
: '';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The modulo operation % 1000 is redundant here. The DateTime.microsecond property is already documented to be in the range of 0 to 999. You can safely remove the modulo for cleaner code.

Suggested change
final us = (dt.microsecond > 0)
? (dt.microsecond % 1000).toString().padLeft(3, '0')
: '';
final us = (dt.microsecond > 0)
? dt.microsecond.toString().padLeft(3, '0')
: '';

Comment thread test/types/xsd_datetime_test.dart
@mark-dropbear
mark-dropbear merged commit d44c95c into main Nov 26, 2025
1 check passed
@mark-dropbear
mark-dropbear deleted the datetime-new branch November 27, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant