Repository navigation
feat: add xsd:datetime codec and data type - #66
Conversation
Summary of ChangesHello @mark-dropbear, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the library's capability by adding full support for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for the xsd:datetime data type. It adds a new XsdDateTime wrapper class to handle XSD's specific requirements for timezones, particularly 'floating' datetimes and preserving the original offset for round-tripping. A corresponding codec and unit tests are also included. The implementation is well-structured and the code is clear. I've left a couple of suggestions for minor improvements: one to simplify the code in the XsdDateTime class and another to enhance the test suite with cases for fractional seconds.
| final us = (dt.microsecond > 0) | ||
| ? (dt.microsecond % 1000).toString().padLeft(3, '0') | ||
| : ''; |
There was a problem hiding this comment.
The modulo operation % 1000 is redundant here. The DateTime.microsecond property is already documented to be in the range of 0 to 999. You can safely remove the modulo for cleaner code.
| final us = (dt.microsecond > 0) | |
| ? (dt.microsecond % 1000).toString().padLeft(3, '0') | |
| : ''; | |
| final us = (dt.microsecond > 0) | |
| ? dt.microsecond.toString().padLeft(3, '0') | |
| : ''; |
No description provided.