Skip to content

feat: add xsd:decimal codec - #68

Merged
mark-dropbear merged 3 commits into
mainfrom
decimal
Nov 27, 2025
Merged

mark-dropbear merged 3 commits into
mainfrom
decimal

Conversation

@mark-dropbear

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @mark-dropbear, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces full support for the xsd:decimal XML Schema data type within the library. By adding a new codec, the library can now accurately parse and serialize decimal numbers, ensuring compliance with XSD 1.1 specifications and enhancing the precision of numerical data handling. This change improves the robustness and completeness of the library's datatype support.

Highlights

  • New Codec Implementation: A new XsdDecimalCodec has been implemented to handle the xsd:decimal XML Schema data type, allowing for precise encoding and decoding of decimal values.
  • Documentation Updates: The CHANGELOG.md has been updated to reflect the addition of the xsd:decimal codec, and the README.md now marks xsd:decimal as fully supported in the datatype compatibility table.
  • Comprehensive Testing: Dedicated unit tests have been added for the XsdDecimalCodec, covering various scenarios including valid encoding, valid decoding (with whitespace handling), and error handling for invalid decimal formats.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a codec for the xsd:decimal data type, complete with implementation, tests, and updates to documentation. The implementation is well-done, correctly handling whitespace collapsing and validation as per the XSD specification. The tests cover the primary scenarios. My review includes suggestions to enhance test coverage for decimal parsing to ensure robustness and to add missing newline characters at the end of a couple of files, which is a common convention.

Comment thread CHANGELOG.md
Comment thread lib/src/codecs/codecs.dart Outdated
Comment thread test/codecs/decimal_codec_test.dart
@mark-dropbear
mark-dropbear merged commit 6fc3a0b into main Nov 27, 2025
1 check passed
@mark-dropbear
mark-dropbear deleted the decimal branch November 27, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant