Open
Conversation
Owner
|
Thanks! I'll take a look through. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have been using this for a few weeks with 3.7 and no issue. I've tried to retain backwards compatibility, and I'm sure that this worked with puppet 3.4, although not very sure whether in an older code shape or in current rebase. Regarding older clients, /api/v1/releases.json is not ported in any way. It's a very complex operation, and my rewrite attempts did end with puppet client timeouts. Fortunately, it is served by current puppet V3 forge, so I'f left basically unchanged.
There is also an issue on modules served from git repositories, because V3 metadata includes a checksum of the tar.gz, and seems that creating them on the fly does not produce always the same md5, so that part of acceptance tests do randomly fail, although usually succeed after one or two retries.
The offline_proxy_forge_integration test is disabled because librarian-puppet ends with a query to V1 api that cannot be resolved, and I've also disabled a few of rspec examples for whom I did only get quite ad-hoc fixes.
Resolve #6