chore(changelog): record the task_delete cascade deployment on stage - #185
Closed
aaron-tsar wants to merge 1 commit into
Closed
aaron-tsar wants to merge 1 commit into
aaron-tsar wants to merge 1 commit into
Conversation
The routine has carried the cascade here since 569976f, but stage was still running the parent-only version, so a task with subtasks left orphans behind. Applied to all 1492 entity databases and the factory template caches, which had to be rebuilt because a new workspace is cloned from them. Also records that bin/patch.js on the stage host is older than this repository and its common target silently skips every organization database.
Contributor
Author
|
Superseded by #187, which carries this change cherry-picked onto preview together with the other two open PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Records in
patches/changelog.txtthatcommon/procedures/task/task_delete.sqlwas deployed to the stage endpoint on 2026-09-21.No routine changes here — the cascade has been in this repository since
569976f(2026-08-21) andpreviewandmainagree. Only stage was behind.Why it mattered
Stage was running the parent-only version, so deleting a task with subtasks left every child behind as an orphan: on no board, removable by nothing.
The stale copy is detectable from a client without database access. The old body ends in
SELECT ROW_COUNT() AS affectedandROW_COUNT()is BIGINT, soaffectedarrives as a string; the current body assigns it to aDECLARE … INTlocal first, so it arrives as a number. In one probe run against one session,task.comment_deletealready answered with a number whiletask.deleteanswered with a string — which is what proved a deployment gap rather than a logic bug.What was applied
hub, 450drumate, 53organization./tmp/drumee-template-{hub,drumate}.sqlfactory caches were rebuilt. A new workspace is cloned from them and they still held the old routine, so patching the live databases alone would have left every workspace created afterwards broken.Verified on a freshly provisioned hub:
affectedcame back a number, the subtask id was returned, and the subtask was actually gone. 77 task contract probes, 0 blocked.One thing for whoever patches next
bin/patch.json the stage host is older than this repository. Itscommontarget readstype IN ('drumate','hub')where this repo readstype IN ('drumate','hub','organization'), so it silently skipped all 53 organization databases — they had to be patched by listing them explicitly. Worth updating the host checkout before the nextcommonrun.150 further databases still carry the old routine. None has an
entityrow and none holds anytaskrow, so nothing reachable by the product runs them.