Conversation
The folder chip never appeared on a media.copy notification, and the reason is a precedence rule that is correct for every other media event and backwards for this one. _stampFolderNames reads the parent id from `dest` first, then `src` — right for an upload or a move, where dest is where the file ended up in the workspace being notified. A copy is filed against the SOURCE hub, so `hubId` resolves to the workspace the file was copied OUT of, while `dest.parent_id` is a folder in the copier's own personal space. The lookup therefore paired a destination node id with the source hub id, matched nothing, and the chip was silently dropped. Had those ids ever collided it would have been worse than a missing chip: the row would have named a folder the reader has no access to. media.copy now reads src first and still falls back to dest, because a handful of prod rows carry an empty `src` object. Every other event keeps dest precedence untouched. Covered by three new cases in activity-folder-name.test.js, which slices the real method out of this file rather than copying it. Verified they fail without the change (the chip comes back named "WRONG - copier private folder") and pass with it: 44 passed, 0 failed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release preview (UAT-verified, deploy run 34928693409) to PROD: activity copy row names the source folder.