Conversation
…s and Office export
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
…g cache on /file/orig
… label while the editor chunk downloads
…ch the editor chunks
…the office player
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What
Two in-app editors for the desk, both built on Casual Office (Apache/MIT):
editor_docs,.udoc): native .docx editing (ProseMirror + WASM layout), Google-Docs style header with editable title, autosave, Ctrl+S, co-editing and comments through the Casual Docs gateway.editor_sheet,.usheet): Univer based spreadsheet with the full Casual chrome (menus, toolbar, formula bar, comments, tables), dark/light theme, presence avatars and live co-editing through the Casual Sheets server.Also:
.udoc/.usheetproduces a real.docx/.xlsx(builtins/editor/export.js), like Google Docs and Sheets.How it is wired
media.savepath as JSON ({docx: base64}for docs, the Univer workbook snapshot for sheets), so nothing changes server side.<endpoint>/collab/health(docs) and<endpoint>/sheets/health(sheets). When the gateway is not routed the editor silently runs single-user. On stage the gateways run as Docker containers on the box and are currently routed for theliamendpoint only; the root endpoint needs the two nginx locations before co-editing is live there.@univerjs/docs-mention-uiis not published on npm:stubs/univerjs-docs-mention-uiprovides a no-op plugin, referenced frompackage.jsonas afile:dependency.patches/@casualoffice+sheets+0.20.0.patch(patch-package) makes the Casual Sheets lazy plugin loader per Univer instance; upstream keeps it module global, which leaves comments and tables dead in every sheet after the first one.scripts/postinstall-casual.jscopies the Casual Docs layout engine WASM next to the chunk that loads it (the package ships it one directory up)..npmrcturns onlegacy-peer-deps: Casual Docs' peer ranges conflict with the Univer 0.25.1 set Casual Sheets needs. Every peer the build relies on is listed explicitly.Verified
npm install, production webpack build: 0 errors.liamstage endpoint: create, edit, save, reopen, rename, download for both editors; two-tab co-editing, remote cursors, comments with author names, presence; first click works everywhere; no periodic save loop; desk theme untouched.Known limits
[DOCS]/[SHEET]console logs are still in place.