Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Right after creating a workspace (or with any Wm modal open, e.g. Invite), opening the workspace switcher draws the panel under the folder window. The modal dissolves the window manager's isolation, so the focused window's layer (z 50001) escapes to the document root where the top bar (z 10003) loses.
Cause
68294c4 replaced the
:has()lift with adata-desk-wsmenumirror installed bydesk/index.js _installWsMenuMirror, waiting onensurePart("ws-wrapper"). It also addedsys_pn: "ws-wrapper"to the switcher'sSkeletons.Menuliteral, which already declaredsys_pn: "wsmenu"a few lines lower. An object literal keeps the last duplicate key, so the part only ever existed aswsmenu, the promise never resolved, the observer was never installed and the lift rule in desk/skin never matched.A second problem hid behind the first: the observer is bound to one element, and the switcher is re-rendered after desk init.
Fix
wsmenu.onPartReady("wsmenu")so it follows every render.sys_pnand leave a comment so it does not come back.Verified
On the
liamstage endpoint with the fix: opening the switcher stampsdata-desk-wsmenu="1"; with the Invite modal open the top bar computes z 100001 andelementFromPointat the panel's centre hits the menu row.