Fix/task drop zone colors - #613
Conversation
…one colour The description editor lit with the brand tokens on a drag — --hover-bg-40 behind a dashed --active-border frame — while the attachment, create-files and comment surfaces lit orange from a hardcoded rgba(250, 133, 64, 0.08) and a 2px/1px dashed var(--primary, #fa8540). Dragging one file across a single detail card therefore changed colour depending on which half of the card the pointer was over. --primary is defined in neither light.scss nor dark.scss, so those overlays were never themed at all: the orange was always the literal fallback. That is also why the overlay icon and text move here too. They carried the same var(--primary, #fa8540), and recolouring only the background and the frame would have left an orange glyph and orange "Drop files to attach" inside a purple-tinted, purple-dashed box. They take a solid #5950ff fallback rather than the frame's 0.4-alpha one, which would render washed out on 15px type if the theme failed to load. The frames become outlines with outline-offset: -2px rather than borders, matching the rule they are being synced to. An outline paints outside its box by default, so on an inset: 0 overlay it would bleed 2px past the zone it marks; the negative offset puts it back exactly where the border sat. This costs the comment overlays their deliberate 1px dash, the "one size down" treatment for a frame that sits inside a card rather than over a modal. Their content hierarchy is untouched (still no icon, still 13px type) and the stale comment now says so. Verified by compiling the sheet standalone with sass -I src/drumee/skin -I src/sass/helpers and reading back the six zones' computed rules; not verified in a browser. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Deletes tests/ in full: 17 node:test cases and the 8 support files under tests/helpers/ that rendered real skeletons for them. Nothing depended on it. There is no test script in package.json, none of the four workflows in .github/ ran it, and no module outside tests/ required the helpers — the only importers were the cases removed here. So this drops coverage without breaking a pipeline. Worth knowing for whoever rebuilds it: tests/helpers/render-skeleton.js was also the fastest way to verify a skin change headlessly, since it stubbed the Skeletons globals and the webpack aliases and handed back the real descriptor tree. git history is the place to recover that pattern. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d2026dd01
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1,258 +0,0 @@ | |||
| // The Checkout tab must never be taken away from the user. | |||
There was a problem hiding this comment.
This deletion is part of removing all 25 files under tests/, including the task-drop coverage for the code changed here and regression tests for billing, calls, permissions, workspace handling, and other shipped behavior. The resulting tree has no test harness or test cases left, so those regressions can no longer be detected; retain the suite or migrate it to a replacement harness in the same change.
Useful? React with 👍 / 👎.
| $weight: 600, | ||
| $line: 20px, | ||
| $color: var(--primary, #fa8540) | ||
| $color: var(--active-border, #5950ff) |
There was a problem hiding this comment.
When dark mode is active, --active-border resolves to #5950ff while the overlay uses --hover-bg-40 over a dark surface. Even over the darkest #0b0a21 surface this gives the 15px label only about 3.3:1 contrast, and on elevated task surfaces it drops further, whereas the previous orange label exceeded 4.5:1. The 13px comment label has the same regression, so keep the purple affordance if desired but use a dark-mode-readable token for its instructional text.
Useful? React with 👍 / 👎.
1 participant
No description provided.