Skip to content

ci: enforce Rust contract coverage #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
collinsezedike merged 2 commits into from
Aug 30, 2026
+13 −2
Merged

ci: enforce Rust contract coverage #595

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7620a8f
ci: enforce contract coverage
Mojisola001-tech Aug 25, 2026
22b32af
ci: cover adapter common contract
Mojisola001-tech Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,20 @@ jobs:
- name: Run clippy
working-directory: packages/contracts
run: cargo clippy --all-targets -- -D warnings
- name: Run contract tests
- name: Install cargo-llvm-cov
uses: taiki-e/install-action@cargo-llvm-cov
- name: Install LLVM coverage tools
run: rustup component add llvm-tools-preview
- name: Measure contract coverage
working-directory: packages/contracts
run: cargo test
run: >-
cargo llvm-cov
--package meridian-vault

@collinsezedike collinsezedike Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adapter-common is missing from this --package list, so its coverage is never measured, confirmed directly in this run's own output: the printed table only has rows for blend-adapter/src/lib.rs, defindex-adapter/src/lib.rs, and vault/src/lib.rs, no adapter-common row at all. That crate has zero tests of its own (no #[cfg(test)] module) and still has two .unwrap()-based panics in require_vault_auth/get_usdc. #533's own motivation was closing exactly this kind of untested-panic gap in the code that custodies funds, so leaving out the one crate that's actually fully untested undercuts the point of adding the gate. Add --package adapter-common to the list.

@collinsezedike collinsezedike Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --package list omits adapter-common, a workspace member (see packages/contracts/Cargo.toml) whose code is exercised by the other packages' tests but never measured or gated by this 97.5% threshold. Untested branches added to adapter-common can ship at 0% coverage while this gate still passes.

--package meridian-blend-adapter
--package meridian-defindex-adapter
--package adapter-common
--summary-only
--fail-under-lines 97.5
- name: Build wasm
working-directory: packages/contracts
run: cargo build --target wasm32-unknown-unknown --release
Loading