docs: describe the migrate_adapter branch in the testnet adapter-swap section - #666
Open
funmilayo-ui wants to merge 1 commit into
Open
docs: describe the migrate_adapter branch in the testnet adapter-swap section#666funmilayo-ui wants to merge 1 commit into
funmilayo-ui wants to merge 1 commit into
Conversation
The redeploy-blend-adapter.sh script branches on get_total_shares and prints migrate_adapter for a vault with depositors, set_adapter only for a vault with none. The doc still described the pre-drydocs#514 set_adapter-only flow with a manual withdraw-everything step.
|
@funmilayo-ui Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@funmilayo-ui is attempting to deploy a commit to the Collins' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/docs/operations/testnet-deployment.md's "Pushing new adapter code to a live vault" section described the pre-#514 behaviour ofscripts/redeploy-blend-adapter.sh: a single printedset_adaptercommand plus a manual "withdraw everything first" step. The script has branched onget_total_sharesfor a while and printsmigrate_adapterfor a vault that has depositors, reservingset_adapterfor a vault with none.closes #662
Changes
get_total_sharescheck up front to pick between them.migrate_adapter --new-adapter ... --max-slippage-bps 100: atomic move of the vault's whole position, slippage bound in basis points (max10000), per-depositor bookkeeping denominated in vault shares so nobody has to withdraw first, and theSameAdapter/NoAdapterPositionfailure cases.set_adapterdocumented as the zero-depositor path, with theADPT_SH-reset caveat that explains why it is wrong for a vault holding a position.--source \$DEPLOYER, and that key must be the vault admin (admin.require_auth()); the old text said to useADMIN"not DEPLOYER", which does not match what the script emits.Verification
scripts/redeploy-blend-adapter.sh(lines 11-19 and 70-91) andpackages/contracts/vault/src/lib.rsmigrate_adapter(slippage bound,SameAdapter,NoAdapterPosition, share bookkeeping preserved).prettier --check apps/docs/operations/testnet-deployment.md→ "All matched files use Prettier code style!"