docs: fix apps/api mislabel and the broken local-dev filter command - #668
Open
funmilayo-ui wants to merge 1 commit into
Open
docs: fix apps/api mislabel and the broken local-dev filter command#668funmilayo-ui wants to merge 1 commit into
funmilayo-ui wants to merge 1 commit into
Conversation
apps/api does not exist; the Fastify local-dev server is apps/api-local (@meridian/api-local). The root api/ package (@meridian/api) holds the Vercel functions and has no dev script, so the local-development filter command failed as written.
|
@funmilayo-ui is attempting to deploy a commit to the Collins' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@funmilayo-ui Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README.mdandCONTRIBUTING.mdboth listedapps/api/as the Fastify server. That directory does not exist in the repo — the Fastify local-dev server isapps/api-local(@meridian/api-local), which both files already reference correctly elsewhere.local-development.mdthen told readers to runpnpm --filter @meridian/api dev, andapi/package.json(@meridian/api, the Vercel-functions package) defines only atestscript, so that command fails.closes #660
Changes
README.md+CONTRIBUTING.md:apps/api/→apps/api-local/, labelled local-dev only.apps/docs/operations/local-development.md:pnpm --filter @meridian/api dev→pnpm --filter @meridian/api-local dev.api/(Vercel serverless functions, the production API) andpackages/api-core/(the handlers both servers share). Without them the trees imply the Fastify server is the API.Verification
ls apps→api-local docs landing web; there is noapps/api.apps/api-local/package.json: name@meridian/api-local, has"dev": "tsx watch src/index.ts".api/package.json: name@meridian/api, scripts are{ "test": ... }only — hence the failure reported in the issue.packages/→api-core contracts shared stellar-sdk-helpers.prettier --checkon all three files → clean. Docs-only change, no code touched.