fix: translate ErrorBoundary fallback text - #673
Open
DevTobis wants to merge 1 commit into
Open
Conversation
Wrap ErrorBoundary with react-i18next's withTranslation HOC (it's a class component, so the useTranslation hook doesn't apply) and route the fallback heading and reload button through errorBoundary.title / errorBoundary.reload in en.json and fr.json.
|
@DevTobis is attempting to deploy a commit to the Collins' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@DevTobis Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #646
Summary
ErrorBoundary's fallback heading and reload button were hardcoded English literals — the rest of the app is fully translated viaen.json/fr.json.Changes
ErrorBoundaryis a class component, so theuseTranslationhook can't be used directly inside it. Wrapped it with react-i18next'swithTranslationHOC instead, which injects atprop and keeps the fallback UI reactive to language changes.t("errorBoundary.title")and the button viat("errorBoundary.reload")errorBoundarysection toapps/web/messages/en.jsonandfr.jsonErrorBoundary.test.tsxto mockwithTranslation(matching how other component tests mockuseTranslation) and assert on the translation keysVerification
pnpm --filter=web test— 16 files / 90 tests passedpnpm --filter=web typecheck— cleanpnpm --filter=web lint— clean