test: add coverage for Toasts.tsx - #676
Open
royalTreasure wants to merge 1 commit into
Open
Conversation
|
@royalTreasure Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@royalTreasure is attempting to deploy a commit to the Collins' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #659
Summary
Toasts.tsx(the component rendering toast state) had no test coverage — only the underlying store (toast.test.ts) was tested. AddedToasts.test.tsxcovering the component's per-kind rendering logic.Changes
apps/web/src/__tests__/components/Toasts.test.tsx, seeding the realuseToastStoreviasetState(matching this repo's convention, e.g.VaultPanel.test.tsx's use ofuseWalletStore.setState).Coverage added
success/error/info) renders its correct icon and style classes.errortoast getsrole="alert"andaria-live="assertive"";success/info` toasts get neither.dismisswith that toast's id, leaving other toasts untouched.Verification
npx vitest run src/__tests__/components/Toasts.test.tsx— 4/4 pass.apps/websuite: 83/83 tests pass (including the 4 new ones). 3 pre-existing test files (unrelated to Toasts) fail to even load, independent of this change — they error on resolving the@meridian/sharedworkspace import (e.g.useVaultActions.test.ts), which looks like a pre-existing workspace-linking/build gap in this environment, not something this PR touches.