chore: remove unused vaultPanel.protocol/shares translation keys - #677
Open
royalTreasure wants to merge 1 commit into
Open
chore: remove unused vaultPanel.protocol/shares translation keys#677royalTreasure wants to merge 1 commit into
royalTreasure wants to merge 1 commit into
Conversation
|
@royalTreasure is attempting to deploy a commit to the Collins' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@royalTreasure Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #649
Summary
vaultPanel.protocolandvaultPanel.shareswere defined in bothapps/web/messages/en.jsonandfr.jsonbut never referenced by anyt()call.Changes
en.jsonandfr.json.Verification
apps/web/src) confirms no remaining references to either key (the onebestVault.protocolhit inVaultPanel.tsxis a data field access, unrelated to the i18n key).src/__tests__/i18n.test.ts(en/fr key-parity check) passes.apps/websuite: 79/79 tests pass. 3 pre-existing test files (unrelated to this change) fail to load — they error resolving the@meridian/sharedworkspace import in this environment, same as onmainbefore this change.