Skip to content

fix(vault): revert deposit if adapter credits zero shares (554) - #678

Open
Olalolo22 wants to merge 1 commit into
drydocs:mainfrom
Olalolo22:issue-554
Open

fix(vault): revert deposit if adapter credits zero shares (554)#678
Olalolo22 wants to merge 1 commit into
drydocs:mainfrom
Olalolo22:issue-554

Conversation

@Olalolo22

Copy link
Copy Markdown

Summary

Closes 554
Prevents the vault from minting unbacked vault shares to a depositor if the underlying adapter returns 'o' during 'deposit()'.

Changes
*** ErrorEnum: added 'adaptercreditednothing = 15' to 'contracterror' without renumbering existing variants ro maintain ABI compatibility

@drips-wave

drips-wave Bot commented Aug 31, 2026

Copy link
Copy Markdown

Hey @Olalolo22! 👋 It looks like this PR isn't linked to any issue.

If this PR is for one of the issues assigned to you as part of a Wave, please link it to ensure your contribution is tracked properly. You can do this by adding a keyword to the PR description (e.g., Closes #123), or by clicking a button below:

Issue Title
#554 [Bug] deposit() mints vault shares without checking the adapter credited any Link to this issue

ℹ️ Learn more about linking PRs to issues

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

@Olalolo22 is attempting to deploy a commit to the Collins' projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant