test(sdk): cover keeper-tx error classification helpers - #679
Open
DevQwinB wants to merge 1 commit into
Open
Conversation
keeper-tx.ts had no test file even though its classification helpers are pure and decide retry behaviour: isTransientKeeperError, expectString, isDefinitiveOnChainFailure, isStaleAdapterError and rawErrorText. Covers the cases that matter for correctness: SubmissionFailedError is never transient regardless of its message text, SubmissionInFlightError always is, transient keywords match case-insensitively, and status codes only match on word boundaries so a ledger number containing 503 is not misread as a retryable status.
|
@DevQwinB is attempting to deploy a commit to the Collins' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@DevQwinB Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #657
Summary
packages/stellar-sdk-helpers/src/keeper-tx.tshad no test file, even though itsclassification helpers are pure and directly decide keeper retry behaviour. Adds
keeper-tx.test.tscovering them.Changes
packages/stellar-sdk-helpers/src/keeper-tx.test.ts:isTransientKeeperError—falseforSubmissionFailedErroreven when thewrapped message contains transient keywords,
trueforSubmissionInFlightError, case-insensitive keyword matching("try again", "timeout", "timed out", "rate limit", "temporarily"),
all five retryable status codes (429/500/502/503/504), and the word-boundary
guard (
ledger 15034,amount 4290000stay non-transient).expectString— returns a string unchanged; throws a message naming themethod, contract, and actual type for
null, a number, andundefined.isDefinitiveOnChainFailure— matches waitForTransaction's "failed on-chain"message, not its "Timed out waiting..." message.
isStaleAdapterError— detected by message text (notinstanceof), so itsurvives being rewrapped by
withKeeperRetry.rawErrorText— keeps every line (unlikeerrorMessage), stringifiesnon-Error throws.
No production code changed.
Verification
Run in
packages/stellar-sdk-helpers:pnpm test→ 16 files, 299 tests passing (15 of them new).pnpm coverage→ thresholds pass;keeper-tx.tsat 95.83% stmts / 93.75% branches.pnpm typecheck→ clean.prettier --checkon the new file → clean.Note: a fresh checkout needs
pnpm buildinpackages/sharedfirst (itsdist/is what
@meridian/sharedresolves to); without it every test file in thispackage fails to resolve the import. That is pre-existing and unrelated to this
change.