Skip to content

fix(web): disable deposit and withdraw submit on zero or negative amounts #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Otfrugger wants to merge 1 commit into
base: main
Choose a base branch
from
+41 −1
Open

fix(web): disable deposit and withdraw submit on zero or negative amounts #686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions apps/web/src/__tests__/components/DepositTab.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,22 @@ describe("DepositTab", () => {
expect(onSubmit).toHaveBeenCalledTimes(1);
});

it("disables the submit button when amount is zero", () => {
renderDepositTab({ amount: "0" });
expect(screen.getByTestId("vault-deposit-submit")).toHaveProperty(
"disabled",
true
);
});

it("disables the submit button when amount is negative", () => {
renderDepositTab({ amount: "-1" });
expect(screen.getByTestId("vault-deposit-submit")).toHaveProperty(
"disabled",
true
);
});

it("disables the submit button when amount is empty", () => {
renderDepositTab({ amount: "" });

Expand Down
16 changes: 16 additions & 0 deletions apps/web/src/__tests__/components/WithdrawTab.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,22 @@ describe("WithdrawTab", () => {
expect(onSubmit).toHaveBeenCalledTimes(1);
});

it("disables the submit button when amount is zero", () => {
renderWithdrawTab({ amount: "0" });
expect(screen.getByTestId("vault-withdraw-submit")).toHaveProperty(
"disabled",
true
);
});

it("disables the submit button when amount is negative", () => {
renderWithdrawTab({ amount: "-1" });
expect(screen.getByTestId("vault-withdraw-submit")).toHaveProperty(
"disabled",
true
);
});

it("disables the submit button when amount exceeds available shares", () => {
renderWithdrawTab({ amount: "999" });

Expand Down
8 changes: 7 additions & 1 deletion apps/web/src/components/dashboard/DepositTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,13 @@ export function DepositTab({
<button
data-testid="vault-deposit-submit"
onClick={onSubmit}
disabled={!amount || !bestVault || isDepositing}
disabled={
!amount ||
!bestVault ||
isDepositing ||
parseFloat(amount) <= 0 ||
Number.isNaN(parseFloat(amount))
}
className="w-full rounded-xl bg-emerald-600 hover:bg-emerald-500 disabled:bg-gray-800 disabled:text-gray-600 text-white text-sm font-semibold py-3.5 transition-all duration-150 disabled:cursor-not-allowed"
>
{isDepositing ? t("vaultPanel.waiting") : t("vaultPanel.deposit")}
Expand Down
2 changes: 2 additions & 0 deletions apps/web/src/components/dashboard/WithdrawTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ export function WithdrawTab({
!amount ||
!bestVault ||
isWithdrawing ||
parseFloat(amount) <= 0 ||
Number.isNaN(parseFloat(amount)) ||
parseFloat(amount) > (position?.shares ?? 0)
}
className="w-full rounded-xl bg-emerald-600 hover:bg-emerald-500 disabled:bg-gray-800 disabled:text-gray-600 text-white text-sm font-semibold py-3.5 transition-all duration-150 disabled:cursor-not-allowed"
Expand Down