feat(v1): emit RotationVoted event on intermediate votes (#130) - #138
Draft
s6pa1rta3n-lab wants to merge 1 commit into
Draft
feat(v1): emit RotationVoted event on intermediate votes (#130)#138s6pa1rta3n-lab wants to merge 1 commit into
s6pa1rta3n-lab wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #130.
This PR adds the missing intermediate
RotationVotedcontract event when a resolver votes on an open rotation proposal in Tholos v1 (contracts/tholos), providing real-time off-chain visibility into in-flight committee voting progression prior to execution or deadlock cancellation.Changes Made
contracts/tholos/src/lib.rs):#[contractevent] pub struct RotationVotedcontaining:old_resolver: Addressnew_resolver: Addressresolver: Addressapprove: boolyes_votes: u32no_votes: u32contracts/tholos/src/lib.rs):vote_rotation, emitsRotationVotedon theOk(None)still-open proposal path after persisting state to instance storage.contracts/tholos/src/test.rs):test_rotation_vote_emits_eventverifying vote progression across a 5-member committee (3/5 majority required):approve = false-> returnsOk(None)and emitsRotationVoted(yes = 0, no = 1).approve = true-> returnsOk(None)and emitsRotationVoted(yes = 1, no = 1).approve = true-> returnsOk(None)and emitsRotationVoted(yes = 2, no = 1).approve = true-> returnsOk(Some(true))and emitsRotationExecuted+ResolversUpdated.docs/src/CONTRACT.md(vote_rotationdescription and Events table).docs/src/ROTATION_DESIGN.md(vote_rotationdescription).Verification
cargo build -p tholos --target wasm32v1-none --releasepasses.cargo testpasses (all 70tholostests, all 107tholos-v2tests).cargo fmt --all -- --checkpasses.cargo clippy --all-targets --all-features -- -D warningspasses.Payout Routing
0xF46C9F6d70C50BF81ef3588AB523a90a594a2F89GCL6OXAMLD75BMTINA6EMRUDWK5THQUSHMYNLSNBCJAPZJHNYJTUNIBC