fix(tholos-v2): prevent initialize front-running via atomic constructor - #159
Closed
s6pa1rta3n-lab wants to merge 1 commit into
Closed
fix(tholos-v2): prevent initialize front-running via atomic constructor#159s6pa1rta3n-lab wants to merge 1 commit into
s6pa1rta3n-lab wants to merge 1 commit into
Conversation
Collaborator
|
@s6pa1rta3n-lab Closing. #154 has no assignee. Comment on the issue and wait to be assigned before opening a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #154.
In Soroban Protocol 20+, contract deployment and initialization can be front-run if initialization is performed as a separate transaction after deployment.
This PR implements
__constructoronTholosV2incontracts/tholos-v2/src/lib.rs. Soroban invokes__constructoratomically during deployment (DeployWithConstructoron-chain /env.register(TholosV2, (admin, ...))in test environments), guaranteeing the contract instance is configured atomically upon instantiation.Changes
pub fn __constructor(...) -> Result<(), Error>tocontracts/tholos-v2/src/lib.rsdelegating toSelf::initialize(...).Fixture::new()incontracts/tholos-v2/src/test.rsto register the contract with constructor parameters.tholos-v2.Verification
cargo fmt --checkpassed.cargo clippy -p tholos-v2 --all-targets -- -D warningspassed without warnings.cargo test -p tholos-v2passed (108 tests).cargo test -p tholospassed (69 tests).cargo test -p compute-commitmentpassed.Payout Routing
0xF46C9F6d70C50BF81ef3588AB523a90a594a2F89GCL6OXAMLD75BMTINA6EMRUDWK5THQUSHMYNLSNBCJAPZJHNYJTUNIBC