fix(tholos-v2): emit Revealed events on auto-reveal path (#156) - #161
Closed
s6pa1rta3n-lab wants to merge 1 commit into
Closed
fix(tholos-v2): emit Revealed events on auto-reveal path (#156)#161s6pa1rta3n-lab wants to merge 1 commit into
s6pa1rta3n-lab wants to merge 1 commit into
Conversation
Collaborator
|
@s6pa1rta3n-lab Closing. #156 has no assignee. Comment on the issue and wait to be assigned before opening a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
tholos-v2, theRegistration -> Revealphase transition occurs lazily upon the firstrevealorresolve_outcomecall after the registration deadline. Fixed positions (asserter and disputer) have their position weights auto-counted intoagree_weightanddisagree_weight, but previously did not emit correspondingRevealedevents.This PR fixes #156 by emitting
Revealedevents for each fixed position insideopen_reveal_phase, ensuring downstream indexers observe a consistent and complete sequence of position reveals without needing special handling for fixed positions.Changes
Revealed { id, voter, choice }for both fixed voters insideopen_reveal_phaseincontracts/tholos-v2/src/lib.rs.RevealOpenedevent emission order and phase transition state logic.contracts/tholos-v2/src/test.rsverifying event emissions and choice mappings for bothoutcome == trueandoutcome == falseassertions.docs/src/CONTRACT_V2.mdand added an entry todocs/src/CHANGELOG.md.Verification
cargo fmt --check: passedcargo clippy --workspace --all-targets -- -D warnings: passedcargo test --workspace: 185 passed across all workspace cratesPayout Routing
0xF46C9F6d70C50BF81ef3588AB523a90a594a2F89GCL6OXAMLD75BMTINA6EMRUDWK5THQUSHMYNLSNBCJAPZJHNYJTUNIBC