fix(v1): reject resolve call from asserter or disputer (#165) - #170
Closed
s6pa1rta3n-lab wants to merge 1 commit into
Closed
fix(v1): reject resolve call from asserter or disputer (#165)#170s6pa1rta3n-lab wants to merge 1 commit into
s6pa1rta3n-lab wants to merge 1 commit into
Conversation
Collaborator
|
@s6pa1rta3n-lab Closing. #165 has no assignee. Comment on the issue and wait to be assigned before opening a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #165.
In Tholos v1,
resolvechecked if the caller was part of the snapshotted resolver committee (assertion.resolvers) and had not voted yet (assertion.voted), but did not verify whether the resolver was also a party to the dispute (assertion.asserterorassertion.disputer). A resolver who was also the asserter or disputer could vote on their own case, introducing an economic conflict of interest and allowing a party to sway the outcome to win both bonds.Changes:
Error::ConflictOfInterest = 23to theErrorenum incontracts/tholos/src/lib.rs.Tholos::resolverejecting calls whereresolver == assertion.asserter || assertion.disputer.as_ref() == Some(&resolver)withError::ConflictOfInterest.contracts/tholos/src/test.rscovering:Err(Ok(Error::ConflictOfInterest))and assertion state is unmodified.Err(Ok(Error::ConflictOfInterest))and assertion state is unmodified.docs/src/CONTRACT.mdspecification forresolveand error variants.packages/tholos-sdk/src/index.tserror mappings to include23: {message:"ConflictOfInterest"}.Test plan
cargo fmt --check,cargo clippy --workspace --all-targets --locked -- -D warnings, andcargo test --workspace --lockedpass locally (181 passed tests)CONTRACT.mdupdated withConflictOfInterestonresolvePayout Routing
0xF46C9F6d70C50BF81ef3588AB523a90a594a2F89GCL6OXAMLD75BMTINA6EMRUDWK5THQUSHMYNLSNBCJAPZJHNYJTUNIBC