Fix seed data claiming milestone outcomes that never happened on-chain - #175
Merged
collinsezedike merged 4 commits intoSep 4, 2026
Merged
Conversation
collinsezedike
approved these changes
Sep 4, 2026
collinsezedike
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this, clean fix, matches the issue exactly. Merging now.
If you're looking for more, there are several open issues without an assignee yet. If you have a moment, a star on the repo would be appreciated too.
collinsezedike
approved these changes
Sep 4, 2026
collinsezedike
left a comment
Collaborator
There was a problem hiding this comment.
@JohnArayaE thank you for the contribution. This looks good, there is nothing to flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the fabricated terminal milestone statuses from
demos/freelance-escrow/src/data/jobs.ts's seed data. Two milestones (job-1-m1,job-3-m1) were seeded withstatus: "released"despite having noassertionIdset — that status is only supposed to be reachable through a realassert_outcome -> finalize/resolvesequence against the live contract (seeJobsContext.tsx'svoteOnMilestone/finalizeMilestone). The seed data was presenting those outcomes as if they'd actually happened on-chain.All 7 seed milestones across the 3 jobs now start at
status: "in_progress", the one status that doesn't imply a contract interaction took place. None of the seed milestones setsubmittedAtorassertionId. Job/milestone content itself (titles, descriptions, client/freelancer names, amounts) is unchanged — only the fabricated statuses were reset. Any further-along milestone state a visitor sees from here has to come from actually callingsubmitMilestone/disputeMilestone/voteOnMilestone/finalizeMilestonein their own session.Tests added
No tests added — this is a static seed-data change with no new logic paths.
JobsContext.tsxandMilestoneRow.tsxalready handlein_progressfor every other seed milestone; the two changed entries now just use that same, already-covered path.Test plan
pnpm run build(tsc -b && vite build) passespnpm run lint(oxlint) passes — 0 warnings, 0 errors on 19 filesjobs.tsarestatus: "in_progress"with nosubmittedAt/assertionIdsetCloses #146