Skip to content

Fix seed data claiming milestone outcomes that never happened on-chain - #175

Merged
collinsezedike merged 4 commits into
drydocs:mainfrom
JohnArayaE:fix/146-seed-milestone-outcomes
Sep 4, 2026
Merged

Fix seed data claiming milestone outcomes that never happened on-chain#175
collinsezedike merged 4 commits into
drydocs:mainfrom
JohnArayaE:fix/146-seed-milestone-outcomes

Conversation

@JohnArayaE

@JohnArayaE JohnArayaE commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes the fabricated terminal milestone statuses from demos/freelance-escrow/src/data/jobs.ts's seed data. Two milestones (job-1-m1, job-3-m1) were seeded with status: "released" despite having no assertionId set — that status is only supposed to be reachable through a real assert_outcome -> finalize/resolve sequence against the live contract (see JobsContext.tsx's voteOnMilestone/finalizeMilestone). The seed data was presenting those outcomes as if they'd actually happened on-chain.

All 7 seed milestones across the 3 jobs now start at status: "in_progress", the one status that doesn't imply a contract interaction took place. None of the seed milestones set submittedAt or assertionId. Job/milestone content itself (titles, descriptions, client/freelancer names, amounts) is unchanged — only the fabricated statuses were reset. Any further-along milestone state a visitor sees from here has to come from actually calling submitMilestone/disputeMilestone/voteOnMilestone/finalizeMilestone in their own session.

Tests added

No tests added — this is a static seed-data change with no new logic paths. JobsContext.tsx and MilestoneRow.tsx already handle in_progress for every other seed milestone; the two changed entries now just use that same, already-covered path.

Test plan

  • pnpm run build (tsc -b && vite build) passes
  • pnpm run lint (oxlint) passes — 0 warnings, 0 errors on 19 files
  • Manually verified all 7 milestones in jobs.ts are status: "in_progress" with no submittedAt/assertionId set

Closes #146

@collinsezedike collinsezedike left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, clean fix, matches the issue exactly. Merging now.

If you're looking for more, there are several open issues without an assignee yet. If you have a moment, a star on the repo would be appreciated too.

@collinsezedike
collinsezedike merged commit a18d763 into drydocs:main Sep 4, 2026
3 checks passed

@collinsezedike collinsezedike left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohnArayaE thank you for the contribution. This looks good, there is nothing to flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Demo app seed data claims milestone outcomes that never happened on-chain

2 participants