feat(v1): add permissionless timeout fallback for stalled disputes (#166) - #176
Closed
s6pa1rta3n-lab wants to merge 1 commit into
Closed
feat(v1): add permissionless timeout fallback for stalled disputes (#166)#176s6pa1rta3n-lab wants to merge 1 commit into
s6pa1rta3n-lab wants to merge 1 commit into
Conversation
Collaborator
|
@s6pa1rta3n-lab Closing. #166 has no assignee. Comment on the issue and wait to be assigned before opening a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #166. In Tholos v1, when an assertion enters
Status::Disputed, it previously had no mechanism to recover if resolvers became unresponsive, went offline, or failed to reach a majority consensus, leaving both the asserter and disputer bonds locked indefinitely.This PR introduces a permissionless liveness fallback:
stalled_dispute_timeout_secsupon contract initialization (bounded between 1 second andMAX_STALLED_DISPUTE_TIMEOUT_SECSof 21 days).set_stalled_dispute_timeoutand public read viaget_stalled_dispute_timeout.disputed_attimestamp when an assertion is disputed.reclaim_stalled_dispute(id): permissionless fallback callable afterdisputed_at + timeout < env.ledger().timestamp()that transitions the assertion toStatus::Resolvedwithfinal_outcome: Noneand safely refunds both asserter and disputer bonds.CONTRACT.mdandINTEGRATION.md.Verification
cargo fmt --check: Passedshellcheck -x scripts/*.sh scripts/lib/*.sh: Passedcargo clippy --workspace --all-targets --locked -- -D warnings: Passed (0 warnings)cargo test --workspace --locked: 185 tests passed (78 v1, 107 v2)cargo build --workspace --lib --target wasm32v1-none --release --locked: Built successfullypnpm -C packages/tholos-sdk build: Passedpnpm -C demos/freelance-escrow build: PassedPayout Routing
0xF46C9F6d70C50BF81ef3588AB523a90a594a2F89GCL6OXAMLD75BMTINA6EMRUDWK5THQUSHMYNLSNBCJAPZJHNYJTUNIBC