feat(agent-skills): add karpathy-skills + auto-discover all marketplaces#831
Merged
Conversation
Adds forrestchang/andrej-karpathy-skills (113k★) to both the Claude
marketplace and the tool-agnostic agent-skills tree.
Claude: `andrej-karpathy-skills@karpathy-skills` enabled in Tier 5
(behavioral/workflow). One skill: karpathy-guidelines (Think Before
Coding, Simplicity First, Surgical Changes, Goal-Driven Execution).
Agent-skills: refactored from a hardcoded 5-marketplace list to
auto-discovery via `walkAllPatterns`. The walker tries flat /
.claude/skills / perPlugin layouts plus one-level subpath walks
("plugins", "external_plugins") against every input in
marketplaceInputs. No marketplace names are hardcoded in the module —
it is fully decoupled from Claude's registry and ready for the
planned module split. Future skill-providing marketplaces require zero
agent-skills edits.
lib.optionals used instead of if/then/else in walkAllPatterns to keep
the edit within the inline-script-guard threshold.
Assisted-by: Claude <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request integrates the karpathy-skills repository and refactors the skill discovery mechanism in modules/agent-skills/default.nix to automatically scan all marketplace inputs using a generic pattern-matching approach. Feedback was provided to enhance the robustness of the directory traversal logic by verifying entry types before processing them to avoid potential evaluation errors.
Cache the root directory listing once and verify each subpath
("plugins", "external_plugins") is itself a directory before
recursing into discoverSkills/discoverClaudeCommands. builtins.readDir
throws on regular files, so the prior pathExists check could fail
loudly if a marketplace happened to ship a file with one of those
names. Addresses Gemini review feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restoring abandoned 17-day-old local branch.
Commits
Summary
Adds forrestchang/andrej-karpathy-skills (113k stars) to both the Claude marketplace and the tool-agnostic agent-skills tree.
Opened as draft for review. Re-baseline against main before promoting.
Assisted-by: Claude noreply@anthropic.com