Add manifest-based orphan cleanup for non-force sync mappings#32
Merged
Conversation
When files are renamed in the dotfiles repo, the old file remained as an orphan in the destination. This adds manifest tracking so dotsync detects and removes orphaned files on subsequent pulls. - Add sync_type attribute and manifest_key to Mapping model - Pass sync_type through SyncMappings shorthand conversion - Create Dotsync::Manifest utility (read/write/orphans) - Add cleanup_orphans to MappingsTransfer with dry-run preview - Call cleanup_orphans in PullAction after transfer_mappings Closes #31 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onlyfilters — force-mode already handles cleanup$XDG_DATA_HOME/dotsync/manifests/<key>.jsonChanges
sync_typeattribute,manifest_keymethod, publichas_inclusions?sync_typethrough shorthand conversionDotsync::Manifest: Read/write/orphan detection utilitycleanup_orphansmethod + dry-run orphan previewcleanup_orphansaftertransfer_mappingsxdg_data_homefor manifest storageCloses #31
Test plan
bundle exec rspec— 536 examples, 0 failuresonly, pull, rename file, pull again — verify orphan removed🤖 Generated with Claude Code