Fix backup to respect only/ignore filters#38
Merged
Conversation
Backup was copying entire destination directories ignoring the mapping's only/ignore filters, causing permission crashes on restricted files (e.g. .git objects) and wasting disk space. Replaced cp_r_regular_files with FileTransfer reuse by creating a backup mapping that preserves the original filters. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cp_r_regular_fileswithFileTransferreuse — backup now creates a mapping withsrc=dest, dest=backup_pathpreserving originalonly/ignorefilterscp_r_regular_files)onlyfilter,ignorefilter, and permission-restricted files outside filterCloses #37
Test plan
dotsync pull --apply -yno longer crashes on~/.config/claude/plugins/rm -rf ~/.local/share/dotsync/backups/to clean up bloated backups🤖 Generated with Claude Code