Maximize cached diff reuse to eliminate redundant directory traversals (#43)#44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminates two redundant full directory traversals per mapping in force mode by reusing data already computed during the diff phase. Also skips the orphan preview scan when no differences exist.
Closes #43
Changes
Code
DirectoryDiffer: Build source index during first walk; removebuild_source_indexmethodDiff: Addremoval_rel_pathsfield for relative removal pathsFileTransfer: Acceptremovals:keyword; newremove_precomputed_filesmethod; backward-compatible fallback tocleanup_folderMappingsTransfer: Pair diffs with mappings intransfer_mappings; gateshow_orphan_previewbehindhas_differences?Tests
removal_rel_pathsFileTransfer.newmocks in pull/push specs for new keyword argTest plan
bundle exec rspec— 552 examples, 0 failuresbundle exec rubocop— passed (pre-commit hook)