Skip to content

Refresh YieldModelingWorkshopTutorial Notebooks #445

Description

@MalichiMerski

Feel free to modify the problem statement below. The objective of this problem report is to identify any findings against the YieldModelingWorkshop notebooks and fix them.

A Yield Modeling Workshop was performed for the summers of 2023 and 2024. The Google Colab code needs minor updates to ensure continued functionality.

Notebook locations: https://github.com/dsavransky/YieldModelingWorkshopTutorial/tree/main/Notebooks

Issues:
https://github.com/dsavransky/YieldModelingWorkshopTutorial/blob/main/Notebooks/EXOSIMS_tutorial1.ipynb

  • For code block setting up plotting: There is an error while setting up the plot. Modifying "widget" to "inline" after %matplotlib appears to resolve the issue.
  • For code block taking a look at planets' physical and orbital attributes: There is a UnitConversionError. Appending ".value" to "s=sim3.SimulatedUniverse.Rp" and "c=sim3.SimulatedUniverse.Rp" appears to resolve this issue.
  • For code block with consistent masses and radii: Appending ".value" to "s=sim4.SimulatedUniverse.Rp" and "c=sim4.SimulatedUniverse.Rp" appears to resolve this issue.
  • For code block beginning to extrapolate: Appending ".value" to "s=sim5.SimulatedUniverse.Rp" and "c=sim5.SimulatedUniverse.Rp"" appears to resolve this issue.
  • For code block computing integration times for a range of delta mag values: A UnitConversionError seems to originate from the EXOSIMS library and not the code itself. A unit mismatch appears to exist for mode['losses'] parameter. Suggestion to review the EXOSIMS library and associated calculations to investigate and resolve this issue.

https://github.com/dsavransky/YieldModelingWorkshopTutorial/blob/main/Notebooks/Completeness_figures.ipynb

  • For code block setting up plotting: There is an error while setting up the plot. Modifying "widget" to "inline" after %matplotlib appears to resolve the issue.
  • For code block adding instrumental bounds: Modify "TL.default_mode["IWA"] to "TL.OpticalSystem.IWA" and "TL.default_mode["OWA"] to "TL.OpticalSystem.OWA" since TargetList does not appear to contain ".default_mode" attribute.
  • For code block showing how IWA/OWA and completeness scale with stellar distance: same issue as described above. Change format to access attributes of OpticalSystem instead.

Note: EXOSIMS_tutorial2_colab.ipynb did not contain any issues.

EXOSIMS version: v3.6.5

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions