Prevent redistributing Minecraft official jar#304
Open
Kamesuta wants to merge 3 commits intodscalzi:masterfrom
Open
Prevent redistributing Minecraft official jar#304Kamesuta wants to merge 3 commits intodscalzi:masterfrom
Kamesuta wants to merge 3 commits intodscalzi:masterfrom
Conversation
This was referenced Oct 1, 2023
Contributor
|
Interesting concept, however I'm not sure if @dscalzi is okay to rely on third-party tools |
Contributor
Author
I created the ForgeInstallerCLI with reference to ForgeWrapper (third-party tool), but it is not dependent on it. |
GeekCornerGH
suggested changes
Mar 12, 2024
Contributor
GeekCornerGH
left a comment
GeekCornerGH
left a comment
There was a problem hiding this comment.
Fabric has landed, please rebase your changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent redistributing Minecraft official jar
Problem
HeliosLauncher includes Minecraft client jar in the distribution for versions 1.13 and above. This violates the EULA and poses a risk of receiving a DCMA request.
Solution
This pull request changes the launcher to run the Forge installer instead of bundling the jar file.
Implementation
I created a project called ForgeInstallerCLI, which allows running the Forge installer from the command line. It is based on the ForgeWrapper functionality, but with added support for getting installation progress. I made this project for HeliosLauncher, so I would like to transfer it to you if possible.
Notes
The installer is currently run in the frontend process. If needed, I can re-implement it in a fork process instead. Please let me know if you have any feedback or suggestions.
Related PRs
I also submitted separate pull requests for dscalzi/Nebula#65 and dscalzi/helios-core#3, which are required for this change to work.