Skip to content

🔒 [security fix] Insecure Temporary File Creation in encode.moon #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dsetareh wants to merge 1 commit into from
Closed

🔒 [security fix] Insecure Temporary File Creation in encode.moon #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/encode.moon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ find_path = (startTime, endTime) ->
if is_stream
if mp.get_property('file-format') == 'hls'
-- Attempt to dump the stream cache into a temporary file
path = utils.join_path(parse_directory('~'), 'cache_dump.ts')
path = get_temp_path('.ts')
mp.command_native({
'dump_cache',
seconds_to_time_string(startTime, false, true),
Expand Down Expand Up @@ -445,4 +445,4 @@ encode = (region, startTime, endTime) ->
-- Clean up pass log file.
os.remove(get_pass_logfile_path(out_path))
if is_temporary
os.remove(path)
cleanup_temp_file(path)
5 changes: 5 additions & 0 deletions src/main.moon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,10 @@ mainPage = MainPage!
mp.add_key_binding(options.keybind, "display-webm-encoder", mainPage\show, {repeatable: false})
mp.register_event("file-loaded", mainPage\setupStartAndEndTimes)

mp.register_event "shutdown", ->
for path, _ in pairs temp_files_to_clean
msg.verbose "Cleaning up temporary file: #{path}"
os.remove path

msg.verbose("Loaded mpv-webm script!")
emit_event("script-loaded")
Loading
Loading