fix: don't mutate the defaultSettings object passed to SettingsContainer#1675
Open
Yanhu007 wants to merge 1 commit intodsherret:latestfrom
Open
fix: don't mutate the defaultSettings object passed to SettingsContainer#1675Yanhu007 wants to merge 1 commit intodsherret:latestfrom
Yanhu007 wants to merge 1 commit intodsherret:latestfrom
Conversation
SettingsContainer stores a direct reference to the passed-in defaultSettings object as _settings. When set() is later called, Object.assign(this._settings, settings) mutates the original object, causing unexpected side effects for callers who reuse the same options object across multiple Project instances. Create a shallow copy for _settings, matching the existing behavior of #defaultSettings. Fixes dsherret#1627
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1627
Problem
SettingsContainerstores a direct reference to thedefaultSettingsobject:When
set()is later called,Object.assign(this._settings, settings)mutates the original object. This means a shareddefaultCompilerOptionsobject gets extra properties (lib,configFilePath) after creating aProject, and those leak into subsequentProjectinstances.Fix
Create a shallow copy for
_settings, matching the existing behavior of#defaultSettings:One-character fix (
Object.assign({}, ...)instead of direct assignment).