Sisco/fix editor replace method#30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Query Region System and SyntaxEditor Replacements
Summary
This PR refactors the entire node query system to fix fundamental issues with how
SyntaxEditorhandles multi-node replacements and range queries likeQuery.Between. The core problem was thatSyntaxEditorwas designed around single-node replacements, but queries can match multiple sibling nodes that need to be replaced atomically.Problem
The original implementation had several shortcomings:
SyntaxEditor.Replace()only handled single-node replacements.Inner(),.Start(),.End()) didn't correctly resolve to slot positions within the parentNodePath.FromNode()was called in hot loops during region enumerationSolution
Introduced a new QueryRegion abstraction that represents a contiguous range of slots within a parent container:
This allows
SyntaxEditorto correctly:Query.Between(start, end))Key Changes
New Files:
IRegionQueryinterfacePathTrackingWalker- O(1) incremental path tracking during tree traversalSyntaxEditorBenchmarks.cs- Comprehensive benchmarks for editor operationsModified Files:
IRegionQueryimplementations to all query typesGetLeadingTrivia/TrailingTriviaandGetFirstLeaf/GetLastLeafhelpersPerformance Optimizations
NodePath.FromNode())GreenLeaf.LeadingTriviaWidth/TrailingTriviaWidthinstead of summing at runtimeKindNodeQueryandBlockNodeQueryTest Coverage
Added 15+ new tests covering:
Query.Betweenwith Replace/Remove/Insert/Edit operationsBreaking Changes
None - all changes are internal. The public
SyntaxEditorAPI is unchanged.Files Changed