Optimize Query.Newline + reduce query/region allocations#34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes
Query.Newlineboth semantically precise (“node occurs after a newline”) and fast by relying on green-node boundary flags instead of scanning trivia. It also removes a small set of high-impact LINQ usages from hot query paths and region resolution to reduce allocations and improve throughput.What Changed
Select(...)/combinator paths with tight loops to avoid iterator/closure allocations.SyntaxEditorregion resolution:NodePathwhen a match is found.Query.NotNewlineis the exact negation under the same context.SyntaxEditormutation tests to ensure green flags stay correct across insert/replace/remove and undo/redo.Query.Newline.Key Files
Benchmarks (NewlineQueryBenchmarks)
Using fixed settings (
--warmupCount 3 --iterationCount 30 --outliers RemoveAll), current branch vsmaster:Select(Query.Newline) - CountSelect(Query.Newline.First()) - First match