Skip to content

skip rts clause when one is already supplied #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karalekas merged 3 commits into from
Oct 12, 2025
Merged

skip rts clause when one is already supplied #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6c72af
skip rts clause when one is already supplied
ecpeterson Sep 26, 2025
3881814
fix another redundant RTS clause
ecpeterson Sep 27, 2025
8a90188
forgot i was trying to do this refactor, may as well finish
ecpeterson Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/courier.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,8 @@ NOTES:

Defines an implicit NIL block from which the user can RETURN."
(assert (zerop timeout) () "Blocking RECEIVE-MESSAGE not currently supported. Consider SYNC-RECEIVE for PROCESS instances.")
(when catch-RTS?
(when (and catch-RTS?
(not (member 'message-RTS clauses :key #'car)))
(setf clauses (append clauses `((message-RTS (error "Got an RTS."))))))
(a:with-gensyms (block-name inbox x)
(a:once-only (address)
Expand Down
3 changes: 2 additions & 1 deletion src/process/dpu-helpers.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ NOTE: `MESSAGE-RTS' replies must be explicitly handled. Otherwise, the default
(multiple-value-bind (,retval ,sr-done?)
;; NOTE: this is implemented inefficiently. we could maintain an end-of-queue
;; pointer across successive unsuccessful receive attempts.
(receive-message (,sync-channel ,sync-message-place)
(receive-message (,sync-channel ,sync-message-place
:catch-rts? ,(null (member 'message-rts sync-clauses :key #'car)))
,@(loop :for (clause-head . clause-body) :in sync-clauses
:collect `(,clause-head
(a:when-let ((,record (process-debug? ,process-name)))
Expand Down
17 changes: 6 additions & 11 deletions src/process/rpc.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,17 +54,12 @@ If `RETURNED?' is supplied and this call generates a `MESSAGE-RTS' reply, then `
(sync-receive (,listen-channel ,message-place)
,@(unless (null returned?)
`((message-RTS
,(etypecase result-place-or-list
(symbol
`(lax-destructuring-bind
,result-place-or-list
nil
,@(body t)))
(list
`(lax-destructuring-bind
,result-place-or-list
(list ,@(mapcar (constantly nil) result-place-or-list))
,@(body t)))))))
(lax-destructuring-bind
,result-place-or-list
,(etypecase result-place-or-list
(symbol 'nil)
(list `(list ,@(mapcar (constantly nil) result-place-or-list))))
,@(body t)))))
(,message-type
(lax-destructuring-bind
,result-place-or-list
Expand Down