fix initial login, fix logout button, fix station retrieval#1
Open
johnwang16 wants to merge 1 commit intodtseto:masterfrom
Open
fix initial login, fix logout button, fix station retrieval#1johnwang16 wants to merge 1 commit intodtseto:masterfrom
johnwang16 wants to merge 1 commit intodtseto:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening the app w/o saved credentials presented a user with an inoperable UI. It looks like the comment block ending on line 842 should not have included that brace in file Elpis/MainWindow.xaml.cs.
The logout button wasn't wired up.
Retrieving stations only resulted in a quickmix station because localStations did not add the non-quickmix stations after init.